Author Topic: Update to Lackey CCG Plugin 2023-12-03  (Read 10567 times)

Offline EmJayBee83

  • Moderator
  • Trade Count: (+1)
  • *****
  • Posts: 5486
  • Ha! It's funny because the squirrel gets dead.
    • -
    • East Central Region
    • mjb Games
Update to Lackey CCG Plugin 2023-12-03
« on: December 03, 2023, 08:05:00 PM »
0
Hey All,

Another Lackey Redemption Plugin update from The Jambi. Included in this are

Roots release

Thanks to the Jambi for getting this set up. If you find issues post in this thread.  I will try to do an updated fix release next weekend.

Cheers,
MJB

Offline TheJaylor

  • Trade Count: (+18)
  • Hero Member
  • *****
  • Posts: 3118
  • Fortress Alstad
    • -
    • North Central Region
    • Redemption with Jayden
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #1 on: December 04, 2023, 12:12:43 AM »
0
Thanks Matt!

I just noticed that Famine in Egypt is in Lackey as "Famine of Egypt". Similarly The gods of Egypt is in as "the gods..." These are both from Israel's Rebellion so hopefully it won't mess up too many decks if we fix them. Just a note for everyone, when a card name changes in the Lackey (which we try not to do), the card will disappear from any decks that it was in. If you happen to notice that a deck in the near-ish future is missing Famine in Egypt or The gods of Egypt, now you know why.

The ORDIR contains a list of all Nativity cards. Currently nothing references evil Nativity cards and evil Nativity cards don't have the identifier listed on the physical cards, but it may be helpful to add the Nativity identifier for each Evil Character in the list since that would be relevant in cases where the Evil Characters are converted. To be thorough, we could also add it to all the listed Evil Enhancements but those can't be converted so there wouldn't be anything that targets them at this point.

There are some older cards that don't have the Nativity identifier that should: Bethlehem (Promo), Son of God "Manger" (Promo), Angel of the Lord (C, D, E, F), and Gifts of the Magi (F).
« Last Edit: December 10, 2023, 09:32:32 PM by EmJayBee83 »

Offline EmJayBee83

  • Moderator
  • Trade Count: (+1)
  • *****
  • Posts: 5486
  • Ha! It's funny because the squirrel gets dead.
    • -
    • East Central Region
    • mjb Games
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #2 on: December 04, 2023, 11:29:26 AM »
0
The ORDIR contains a list of all Nativity cards. Currently nothing references evil Nativity cards and evil Nativity cards don't have the identifier listed on the physical cards, but it may be helpful to add the Nativity identifier for each Evil Character in the list since that would be relevant in cases where the Evil Characters are converted. To be thorough, we could also add it to all the listed Evil Enhancements but those can't be converted so there wouldn't be anything that targets them at this point.

There are some older cards that don't have the Nativity identifier that should: Bethlehem (Promo), Son of God "Manger" (Promo), Angel of the Lord (C, D, E, F), and Gifts of the Magi (F).
This raises a larger question--how do we want to handle identifiers that are not present on a card? To date we have followed the rule that what appears in Lackey matches what is on the card. There are a number of identifiers in ORDIR that are not on cards so we don't include. Do we want to include all of those identifiers as well or is there something special about "Nativity" that warrants us treating it separately from identifiers like "Human" for example?

Offline Reth

  • Moderator
  • Trade Count: (+10)
  • *****
  • Posts: 1283
    • LFG
    • East Central Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #3 on: December 04, 2023, 02:42:46 PM »
0
I had a similar idea recently: In a one time effort all identifiers are attached to every card e.g. via macros or so (Based on Card Names and the ORDIR entries). Afterwards a manual cleanup would be necessary. Starting from there every new card will always get all their identifiers within its data - independent from the identifier being printed on the card or not.

Another alternative would be an improved approach to what ORDIR is doing where cards are assigned to all their identifiers by a unique card key (so not just the card name + set suffix).

Offline TheJaylor

  • Trade Count: (+18)
  • Hero Member
  • *****
  • Posts: 3118
  • Fortress Alstad
    • -
    • North Central Region
    • Redemption with Jayden
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #4 on: December 05, 2023, 01:14:26 AM »
0
My thinking is that the more identifiers we include on Lackey, the better. Often certain identifiers won't be printed on cards for space concerns but with Lackey that's not as much of a factor. Since many people use Lackey and Jambi's card viewer for building decks and generating ideas, then I think having every identifier applicable to a card as a searchable item would make sense, as René brought up. I don't think it's something that's worth devoting a whole lot of time to at the moment for Lackey, so identifiers like "human" probably don't need to be included, but I think it may be worth adding some as the come up here and there. In general, I think people are aware that the Lackey data isn't perfect and exhaustive, so I don't think adding some identifiers that aren't printed means we need to worry about including every identifier in the ORDIR just for consistency.

Just my :2cents: though.

Offline JWJ

  • Trade Count: (0)
  • New Member
  • *
  • Posts: 4
    • -
    • Southwest Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #5 on: December 05, 2023, 07:43:58 PM »
0
Where can I find the link for this update?
JWJ

Offline EmJayBee83

  • Moderator
  • Trade Count: (+1)
  • *****
  • Posts: 5486
  • Ha! It's funny because the squirrel gets dead.
    • -
    • East Central Region
    • mjb Games
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #6 on: December 05, 2023, 09:30:39 PM »
0
The Lackey CCG Plugin Location is
http://www.redemptionquick.com/lackey/updatelist.txt

Enter this in the auto-update url text box.

There is copied from the stickied post on this forum called "Lackey CCG Plugin Location"

Offline Bobby Fritts

  • 16plus
  • Trade Count: (+1)
  • *
  • Posts: 6
    • -
    • Northeast Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #7 on: December 06, 2023, 10:45:01 PM »
0
A Lackey user reported that The Amalekite's Slave (Roots) has "GE" as its type, while its type should be "Evil Character". I just checked the spreadsheet and this error persists there, as well. The same thing goes for #141 Silly Women, #142 Self, and #143 Laban, the Deal Breaker (The Amalekite's Slave is #140). All of these Roots cards are listed as "GE" in both Lackey and the spreadsheet, but should be listed as "Evil Character".
« Last Edit: December 10, 2023, 09:31:40 PM by EmJayBee83 »

Offline EmJayBee83

  • Moderator
  • Trade Count: (+1)
  • *****
  • Posts: 5486
  • Ha! It's funny because the squirrel gets dead.
    • -
    • East Central Region
    • mjb Games
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #8 on: December 10, 2023, 09:30:37 PM »
+1
I have updated the Lackey Plugin to resolve the issues reported above (I have crossed them out in the original posts).

I did not add Nativity identifiers. If this is desired, someone else should do create a branch with a wholesale update for this and do a PR against the repository.
« Last Edit: December 10, 2023, 09:32:57 PM by EmJayBee83 »

Offline Bobby Fritts

  • 16plus
  • Trade Count: (+1)
  • *
  • Posts: 6
    • -
    • Northeast Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #9 on: December 25, 2023, 04:14:14 PM »
0
Is this now the preferred place to report perceived errors in Lackey data? I know there was previously another forum in use, and I'm not sure if this one was specifically for the Roots release and first post-release patch or if this is the current place moving forward.

A Redemption CCG Viewer user reported that "Patience (EC)" was not searchable via the "Fruit of the Spirit" identifier. thejambi is now aware of this. Also, the spreadsheet currently contains the identifier. However, the identifier is missing from the card in Lackey, as well.

Offline EmJayBee83

  • Moderator
  • Trade Count: (+1)
  • *****
  • Posts: 5486
  • Ha! It's funny because the squirrel gets dead.
    • -
    • East Central Region
    • mjb Games
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #10 on: December 27, 2023, 06:35:47 PM »
0
Is this now the preferred place to report perceived errors in Lackey data? I know there was previously another forum in use, and I'm not sure if this one was specifically for the Roots release and first post-release patch or if this is the current place moving forward.

A Redemption CCG Viewer user reported that "Patience (EC)" was not searchable via the "Fruit of the Spirit" identifier. thejambi is now aware of this. Also, the spreadsheet currently contains the identifier. However, the identifier is missing from the card in Lackey, as well.
This (the latest update post) is the best place to list issues found in the Lackey plugin. That gives us a single place to look when we do the next update. Thanks for the report.


Offline Bobby Fritts

  • 16plus
  • Trade Count: (+1)
  • *
  • Posts: 6
    • -
    • Northeast Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #11 on: March 19, 2024, 10:11:50 AM »
0
In addition to the new promos added, the following revisions have been made to the spreadsheet. Idk if they are feasible to correct in Lackey, in the next update:

Modified:   
The Judean Mediums [TPC]   Added set due to duplicate card.
Zeresh, Wife of Haman   Fixed Name
Given to Egypt [RR]   Fixed Name
Armor Bearer [RR]   Fixed Name

Also, a player reported that Swift Horses (Roots) is listed as Warrior Class, when it should be Weapon Class. The spreadsheet currently has this correct.
« Last Edit: March 21, 2024, 12:30:35 AM by Bobby Fritts »

Offline Reth

  • Moderator
  • Trade Count: (+10)
  • *****
  • Posts: 1283
    • LFG
    • East Central Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #12 on: March 21, 2024, 07:29:36 PM »
0
Temple Dedication is missing white brigade

Offline Bobby Fritts

  • 16plus
  • Trade Count: (+1)
  • *
  • Posts: 6
    • -
    • Northeast Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #13 on: April 04, 2024, 08:22:40 PM »
0
A player pointed out that both versions of Wicked Community (Priests and IR) share the exact same, verbatim card name in lackey- "Wicked Community", as opposed to the IR version being named Wicked Community [IR] . Both versions currently have set abbreviations at the end in the spreadsheet. Thought behind this is it may be problematic for importing decks, but not sure how big of a deal that is.

Offline TemurTim

  • Trade Count: (0)
  • New Member
  • *
  • Posts: 3
    • Southwest Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #14 on: April 04, 2024, 08:41:18 PM »
0
To reproduce the bug locally, I'm searching for "Wicked Community" in the search bar. When this happens, the version from priests shows up. But when I set the Set filter to "Israel" the IR version of Wicked Community shows up.

See (https://discord.com/channels/548891400398176259/689949101554532359/1225604918749040710) for a screenshot of this happening

Offline Reth

  • Moderator
  • Trade Count: (+10)
  • *****
  • Posts: 1283
    • LFG
    • East Central Region
Re: Update to Lackey CCG Plugin 2023-12-03
« Reply #15 on: April 08, 2024, 03:32:33 PM »
0
Could this be solved by deactivating the "Combine Reprints" switch?

 


SimplePortal 2.3.3 © 2008-2010, SimplePortal